bzip2-1.0.4 Makefile bug

Greg Schafer diy-linux-dev@diy-linux.org
Wed, 24 Jan 2007 08:00:02 +1100


Hi Guys,

This latest version has introduced a bug for "staged" DESTDIR installs. eg:

make PREFIX=/tmp/staging install

Specifically, the symlinks for bzegrep, bzfgrep, bzless and bzcmp all end up
pointing to the staging area. eg:

$ ls -l /tmp/staging/usr/bin
total 488
-rwxr-xr-x 1 pkgmgr pkgmgr 149426 Jan 23 17:53 bunzip2
-rwxr-xr-x 1 pkgmgr pkgmgr 149426 Jan 23 17:53 bzcat
lrwxrwxrwx 1 pkgmgr pkgmgr     27 Jan 23 17:53 bzcmp -> /tmp/staging/usr/bin/bzdiff
-rwxr-xr-x 1 pkgmgr pkgmgr   2128 Jan 23 17:53 bzdiff
lrwxrwxrwx 1 pkgmgr pkgmgr     27 Jan 23 17:53 bzegrep -> /tmp/staging/usr/bin/bzgrep
lrwxrwxrwx 1 pkgmgr pkgmgr     27 Jan 23 17:53 bzfgrep -> /tmp/staging/usr/bin/bzgrep
-rwxr-xr-x 1 pkgmgr pkgmgr   1677 Jan 23 17:53 bzgrep
-rwxr-xr-x 1 pkgmgr pkgmgr 149426 Jan 23 17:53 bzip2
-rwxr-xr-x 1 pkgmgr pkgmgr  16788 Jan 23 17:53 bzip2recover
lrwxrwxrwx 1 pkgmgr pkgmgr     27 Jan 23 17:53 bzless -> /tmp/staging/usr/bin/bzmore
-rwxr-xr-x 1 pkgmgr pkgmgr   1259 Jan 23 17:53 bzmore

This is a regression from 1.0.3. I've sent a report and patch upstream which
has been acknowledged. For now, I'll add a sed similar to this:

sed -i.bak '/ln .*PREFIX/s,$(PREFIX)/bin/,,' Makefile

Regards
Greg